excluding vendor by default

[jeremyolliver]

I'm not sure what the intentions are on providing defaults, I note that there's currently no files excluded from the default configuration. I'm proposing that the rubocop defaults, should exclude files matching vendor/bundle/**. The reason for this being that it's a default bundle install location for CI servers (it's the default path bundler uses for the --deployment flag, and travis-ci installs the bundle there by default, and that running rubocop over third party dependencies, is not intended at all, as their style preferences are their own, and in any case, not what the user is seeking to check.

I can't think of any really good reasons why vendor/bundle would be wanted to be checked, and in any case, seems a logical default setting to me, unless I'm missing something. Anybody care to provide some counter arguments for why not, or does it sound like a good idea?

[bjeanes]

I'd go one further and say all of vendor/ should be excluded. That directory is patently intended for code that you didn't write but are not installable by the language dependency manager.

[bbatsov]

I guess this makes sense (ignoring the entire vendor/). @jonas054 @yujinakayama What do you think?

[yujinakayama]

👍 for vendor/.

[jonas054]

Some projects have vendor directories further down. How about **/vendor/**?

[bjeanes]

That seems like an increased risk of false positives. I have directories
called vendor in an api that deals with integrations with vendors.
On 13 Feb 2014 09:47, "Jonas Arvidsson" notifications@github.com wrote:

Some projects have vendor directories further down. How about /vendor/
?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/806#issuecomment-35005071
.

[jeremyolliver]

I'm inclined to agree with @bjeanes - false positives probably aren't worth the risk given most projects won't have that setup.

[jeremyolliver]

I Just added a commit here to implement exclusion of vendor/** as that looks like where consensus is heading. Feel free to continue discussion or merge when you're happy

[bbatsov]

@jeremyolliver Please, update the changelog as well.

[bjeanes]

@jeremyolliver also double check your commit message. It looks like you accidentally committed Please enter the commit message for your changes. Lines starting

[jeremyolliver]

Whoops. done and done. I rebased, added an entry into the changelog with a similar format and corrected the extra line in the commit message

[bbatsov]

👍

[jeremyolliver]

Thanks :)