Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort gracefully when interrupted with Ctrl-C #88

Merged
merged 2 commits into from
Apr 23, 2013
Merged

Abort gracefully when interrupted with Ctrl-C #88

merged 2 commits into from
Apr 23, 2013

Conversation

yujinakayama
Copy link
Collaborator

Currently, rubocop dumps dozens of backtrace lines when interrupted with Ctrl-C.

This PR includes following changes, much like RSpec and Cucumber.

  • Does not dump backtraces
  • Exits with status 1
  • With Ctrl-C once
    • Aborts at time of finishing each file
    • Reports summary
  • With Ctrl-C twice
    • Aborts immediately
    • Does not report summary

P.S. Thanks for mentining Guard::Rubocop :)

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 23, 2013

Nice addition, @yujinakayama. Could you, please, update the Changelog as well?

@yujinakayama
Copy link
Collaborator Author

Sorry, I've forgotten.

bbatsov added a commit that referenced this pull request Apr 23, 2013
Abort gracefully when interrupted with Ctrl-C
@bbatsov bbatsov merged commit 7a1ddfb into rubocop:master Apr 23, 2013
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 23, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants