Expand base dir to avoid exception from Pathname

[bquorning]

I have a .rubocop.yml in my project’s main folder, and a .rubocop.yml in my spec folder. After upgrading from 0.19.1 to 0.20.1, I have this issue when running Rubocop from my spec folder:

~$ cd spec && rubocop -c ./.rubocop.yml
different prefix: "/" and "."
/Users/bquorning/.rubies/ruby-2.1.0/lib/ruby/2.1.0/pathname.rb:500:in `relative_path_from'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/path_util.rb:10:in `relative_path'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/config.rb:91:in `path_relative_to_config'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/config.rb:71:in `file_to_include?'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/target_finder.rb:61:in `block in target_files_in_dir'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/target_finder.rb:57:in `select'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/target_finder.rb:57:in `target_files_in_dir'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/target_finder.rb:25:in `find'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/lib/rubocop/cli.rb:28:in `run'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/bin/rubocop:14:in `block in <top (required)>'
/Users/bquorning/.rubies/ruby-2.1.0/lib/ruby/2.1.0/benchmark.rb:294:in `realtime'
/Users/bquorning/.gem/ruby/2.1.0/gems/rubocop-0.20.1/bin/rubocop:13:in `<top (required)>'
/Users/bquorning/.gem/ruby/2.1.0/bin/rubocop:23:in `load'
/Users/bquorning/.gem/ruby/2.1.0/bin/rubocop:23:in `<main>'

Always using an expanded path solves the problem.

cc/ @jonas054

[jonas054]

Thanks! I'm sure it's a good correction, but could you also add a spec example (in cli_spec.rb) that fails without your change?

[bquorning]

Spec added.

[jonas054]

I'm sorry. I forgot to mention that you should also add an entry in CHANGELOG.md. But the code looks good!

[bquorning]

No problem, I’m fine with doing one thing at a time ;-)

I’ve added a line (and myself) to the changelog.

[bbatsov]

@bquorning Please, squash the 3 commits into 1.

[bquorning]

Done

[bbatsov]

Thanks!