Fix bug that would report offenses being auto-corrected when they were not #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,8 @@ def autocorrect(node) | |||
| _receiver, _method, params, selector = *node | |||
| _receiver, _method, params, selector = *node.parent if params.nil? | |||
|
|
|||
| return if params && RANGE_TYPES.include?(params.type) | |||
| fail CorrectionNotPossible if params && | |||
There was a problem hiding this comment.
Convert this to a regular if or extract some helper method.
rrosenblum
force-pushed
the
correction_bug
branch
from
b60369e to
2e89f19
Compare
|
I have extracted a method for the if statement |
bbatsov
added a commit
that referenced
this pull request
Apr 25, 2015
Fix bug that would report offenses being auto-corrected when they were not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fixing the some bugs in the
Samplecop, I noticed that some offenses were reporting that they had been corrected when they were not. I found out that I should be usingfail CorrectionNotPossibleinstead ofreturninautocorrectwhen the error cannot be corrected.