Fix bugs in IfUnlessModifier #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have a look at the failing build, please. |
jonas054
force-pushed
the
fix_if_unless_modifier_bugs
branch
from
bdbcf9c to
1a853c3
Compare
|
Thanks for the reminder! I took the easy way out this time and just upped the |
|
You'll also have to rebase this. |
An EOL comment that follows the condition should still be around after auto-correcting to modifier form.
Just like comments in the body, an EOL comment after end may be difficult to put in a good place, if the statement is changed to modifier form.
Only code and comment lines should count when checking a multiline if.
jonas054
force-pushed
the
fix_if_unless_modifier_bugs
branch
from
1a853c3 to
9f771a4
Compare
|
Rebased. |
|
👍 |
This was referenced Nov 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not entirely clear how best to handle comments around
ifstatements when changing them to modifier form. I came to the conclusion that EOL comments right after the condition can be transferred by auto-correct, but comments afterendneed to be looked at by a person. See if you agree.