Fix bad merge for Style/OptionHash

[wli]

This line was introduced in a5be58e, but accidentally deleted when merging 35ef5ed.

I put this in my .rubocop.yml file.

Style/OptionHash:
  Enabled: true

And got the following error:

Warning: unrecognized parameter Style/OptionHash:Enabled found in .rubocop.yml

It looks like we need to specify Enabled: false by default for it not to complain.

[maxjacobson]

Oo good catch!

[bbatsov]

👍 Thanks!

[jfelchner]

@wli is it correct that I should still be getting this error even if I put:

Style/OptionHash:
  Enabled: true

In my rubocop.yml?

[wli]

@jfelchner Which version of rubocop are you running? This fix is only in master, and hasn't been released yet.

[jfelchner]

@wli latest but I figured since all it was, was adding that to the YAML file, I could just add it to my YAML file and fix it myself.

[wli]

@jfelchner Unfortunately it seems like rubocop complains if the Enabled declaration is missing from https://github.com/bbatsov/rubocop/blob/master/config/default.yml. This is what I fixed in this PR.

Not sure really how the internals play out and if there's any way to fix it yourself locally, but luckily it's just a warning and won't block. Maybe @bbatsov can shine some light on this?

[jfelchner]

👍

[jonas054]

@wli The warning for unrecognized parameter is issued when local configuration contains a parameter that's not found in default configuration, i.e., config/default.yml or the files it inherits from. See Config#validate_parameter_names. So when a parameter is missing in default configuration, it can't be fixed in local configuration.