Add Style/IndentAssignment Cop

[panthomakos]

This is a prequel to #2361. It is enabled by default and properly fixes the auto-correct output that MultilineAssignmentLayout produces.

When assignments span multiple lines, this cop enforces proper indentation on the right-hand-side of the expression. It only corrects the first line, as the remaining lines can be corrected by other cops such as Style/IndentationConsistency.

# bad
value =
if foo
  'bar'
else
  'biz'
end

# good
value =
  if foo # corrected/accepted
  'bar'
else
  'biz'
end

I have also added a fix to Astrolabe::Node#asgn_method_call?. It used to consider != method calls as assignments - which they are not. There were also no tests for this method so I've added them.

[jonas054]

I think this ought to be describe, not context.

[panthomakos]

@jonas054 updated to address your comment

[jonas054]

The code looks good, but there's something wrong. The build fails. Please add spec example(s) that fails the same way that the rubocop self-inspection currently does (if you see what I mean), and fix.

[panthomakos]

@jonas054 The issue was some additional comparison operators that ast_node was counting as assignment operators (such as ===). I've adjusted the list and added some additional tests. I've also added a backup test to indent_assignment_spec.rb to ensure that missing operator calls don't cause failures.

[jonas054]

👍 Looks good but you must rebase on top of the latest master.

[panthomakos]

@jonas054 rebased on top of master

[bbatsov]

This should be frozen and possibly placed higher up the class def. I don't like mixing constants with method definitions.

[bbatsov]

I don't see a test showing that this won't generate an offense:

ala = if bala
           tralala
         end

[bbatsov]

I have also added a fix to Astrolabe::Node#asgn_method_call?. It used to consider != method calls as assignments - which they are not. There were also no tests for this method so I've added them.

Nice!

[alexdowad]

I have also added a fix to Astrolabe::Node#asgn_method_call?

Thanks for fixing my bugs!

[panthomakos]

@bbatsov addressed your comments and rebased off master.

[bbatsov]

👍