Conditional assignment #2416
Merged
Conditional assignment #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
force-pushed
the
conditional_assignment2
branch
from
13cf4e8 to
0154441
Compare
| Description: >- | ||
| Use the return value of `if` and `case` statements for | ||
| assignment to a variable instead of assigning that variable | ||
| inside of each branch |
There was a problem hiding this comment.
Small tweak: end sentence with a period.
|
👍 |
rrosenblum
force-pushed
the
conditional_assignment2
branch
from
0154441 to
15a2d3d
Compare
rrosenblum
force-pushed
the
conditional_assignment2
branch
from
15a2d3d to
b8bb1f0
Compare
|
31st of July? :-) This has been in the works for quite a while. :-) |
Yeah, I have been working on this on and off for quite a while. The design has completely changed on it at least twice. |
|
The code is a bit dense (a few comments here and there might be useful), but overall it looks OK to me. I noticed the tests were pretty exhaustive and that's the most important thing. 👍 |
|
I will add some comments and submit a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.