[WIP] New cop Rails/SafeNavigationOperator
#2545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for the use of `#try` and instead encourages changing it to Ruby 2.3's safe navigation operator - `*.`. The cop is enabled by default. E.g ```ruby obj.try! :id obj&.id ```
| context "with method #{method}" do | ||
| context 'and with a receiver' do | ||
| it 'registers an offense for an invocation with args' do | ||
| inspect_source(cop, "obj.#{method}! :id") |
There was a problem hiding this comment.
The ! should not be here.
| # Checks for use of `#try` or `#try!`. | ||
| class SafeNavigationOperator < Cop | ||
| MSG = 'Prefer `&.` over `ActiveSupport#try!`.' | ||
| INVALID_METHODS = [:try!] |
There was a problem hiding this comment.
I'd call this TARGET_METHODS and freeze the array.
|
@syndbg ping |
|
One more thing - the new cop should make use of the functionality @alexdowad just added about target Ruby versions. |
|
I'll close this for now. Feel free to reopen it if you make any progress with it. |
7 tasks
|
@syndbg any plans to work on this soon or should I pick it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
#2428
Changes
Checks for the use of
#tryand instead encourageschanging it to Ruby 2.3's safe navigation operator -
*..The cop is enabled by default.
E.g
Features (TODOs):
#try!.#try!methods to&..#try.#try.