Fix Windows problems #2665
Fix Windows problems #2665
Conversation
|
Sweet!! I don't use MS products myself, but this is great for those who do! |
|
Appveyor is a great service for testing on Windows. Check out Overcommit's last build and their current config file for a sample. |
|
Not sure why the build is failing on jruby-9.0.1.0. I re-ran it, but it failed again. |
|
Looks like some Parser bug to me. //cc @whitequark |
|
I don't have time right now to chase bugs across RuboCop test suite and there is nothing obviously wrong that I've noticed, so I'm afraid you will have to debug that yourself. |
|
Nothing do do with I don't run Windows or I would help debug. |
|
Oh, yeah. I was looking at some parsing error messages a bit earlier in the output. But this build is still running on Linux... |
Ooh, right. I wonder if that |
jonas054
force-pushed
the
fix_windows_problems
branch
from
f75952f to
175d0fb
Compare
That seems a likely candidate. I've removed that particular change, because it's only needed if you've got your heart set on running Let's see how it goes... |
|
Yes. That did it. |
|
You'll have to rebase. |
E.g. C:/Users/... on Windows.
We can't call FileUtils.ln_s on Windows.
Dir.mktmpdir called with a block fails when it tries to delete the temporary directory if it's not empty.
jonas054
force-pushed
the
fix_windows_problems
branch
from
0c2a78c to
3c90d57
Compare
|
Rebased. |
I did some testing on Windows (mingw) for the first time ever and tried to find solutions for the problems I encountered. The support for drive letter and the skipping of the symlink example are pretty straight forward. Then there's the strange behavior around backticks and temporary directories. Slightly more ugly solutions. See what you think.
Anyway, after these changes I was able to run
bundleandrakein a Windowscmdwindow.