Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails/FindEach cop works with where.not. #2798

Merged
merged 1 commit into from
Feb 7, 2016

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Feb 7, 2016

No description provided.

@pocke pocke force-pushed the find_each_with_not branch 2 times, most recently from a85f953 to a08cfe9 Compare February 7, 2016 05:16
@@ -6,6 +6,10 @@

* Fix auto-correction of `not` with parentheses in `Style/Not`. ([@lumeet][])

### New features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically place this section above Bug Fixes.

@bbatsov
Copy link
Collaborator

bbatsov commented Feb 7, 2016

Please, drop the . from the commit message.

@pocke
Copy link
Collaborator Author

pocke commented Feb 7, 2016

I see.
I'll fix commit message and section in CHANGELOG. And I'll push it.

@pocke pocke force-pushed the find_each_with_not branch from a08cfe9 to 9127922 Compare February 7, 2016 07:39
bbatsov added a commit that referenced this pull request Feb 7, 2016
`Rails/FindEach` cop works with `where.not`
@bbatsov bbatsov merged commit 96c6041 into rubocop:master Feb 7, 2016
@pocke pocke deleted the find_each_with_not branch February 7, 2016 08:13
@pocke
Copy link
Collaborator Author

pocke commented Feb 7, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants