Don't add Style/Alias offense for use of alias in eval_instance blocks #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magni-
force-pushed
the
instance_eval_alias
branch
2 times, most recently
from
59fd4a9 to
c053edf
Compare
| @@ -27,8 +27,11 @@ def on_send(node) | |||
| def on_alias(node) | |||
| # alias_method can't be used with global variables | |||
| return if node.children.any?(&:gvar_type?) | |||
| # alias_method can't be used in instance_eval blocks | |||
| scope_type = scope_type(node) | |||
| return if @must_use_alias | |||
There was a problem hiding this comment.
Once set, the value of @must_use_alias remains and affects the inspection of the next alias found in the same file. I think it's better if you add a third scope type called :instance_eval.
There was a problem hiding this comment.
Ahh good catch, will fix 👍
magni-
force-pushed
the
instance_eval_alias
branch
from
c053edf to
0db9ef9
Compare
|
👍 |
|
@magni- Squash the commit together and rebase on top of the current |
magni-
force-pushed
the
instance_eval_alias
branch
from
0db9ef9 to
5720ed5
Compare
|
@bbatsov done! |
|
Had to rebase this once more myself. The commit is merged now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the
Style/Aliascop.instance_evalblocks are found to be dynamic scope, so Rubocop currently adds an offense when usingaliasinstead ofalias_method, but object instances do not respond toalias_method.Before submitting a PR make sure the following are checked:
master(if not - rebase it)and description in grammatically correct, complete sentences.