Enable symmetrical braces for methods

[panthomakos]

Related to #2914 this change enables
Style/MultilineMethodCallBraceLayout and
Style/MultilineMethodDefinitionBraceLayout with EnforcedStyle: symmetrical by default.

All existing RuboCop code has been auto-corrected.

[bbatsov]

Seems there's a bug in the cop. When there's no element on the first line, the current indentation seems to me to be the preferable one.

[bbatsov]

Hopefully you understand my issue with current behaviour. For me:

something(
  a,
  b,
  c
)

is also symmetrical, as there's no element on the first line after (.

[panthomakos]

@bbatsov I agree with you and I think that symmetrical is a better default for method calls and definitions. I was following what I thought was your and @jonas054's preference from #2914 (hashes and arrays use symmetrical and method calls and definitions use same_line). But I am happy to make the default symmetrical for method calls and definitions as well if that is your preference.

[bbatsov]

But I am happy to make the default symmetrical for method calls and definitions as well if that is your preference.

Well, as I said before - it depends for me on the line length.

Normally I write method calls like this:

method(something,
             else,
             top)

but when I'm short on space I go for:

method(
  something,
  else,
  top
)

Ideally there should be a style that's aware whether the first elem is on the same line as the opening paren and determine from it where the closing paren should be.

[panthomakos]

This cop does exactly that w/ the symmetrical style. I have updated the PR to use the symmetrical instead of the same_line style. PTAL

[bbatsov]

Apart from the failing build - the code looks good to me now.

[panthomakos]

Added one too many lines to one module. Fixed!

[bbatsov]

👍