Do not HTML-escape the markup for ellipses in html formatter #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the formatter causing HTML tags to appear on the generated page when <span class="extra-code">...</span> was added for offense locations spanning multiple lines.
jonas054
force-pushed
the
fix_html_ellipses_bug
branch
from
cc3240b to
ca8b8d6
Compare
|
👍 |
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
…#3217) There was a bug in the formatter causing HTML tags to appear on the generated page when <span class="extra-code">...</span> was added for offense locations spanning multiple lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the formatter causing HTML tags to appear on the generated page when
<span class="extra-code">...</span>was added for offense locations spanning multiple lines.For example: