Move Lint/Eval to Security/Eval #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, but would probably require a |
|
I intentionally did not do some of the work, waiting to see if that idea gain consensus. |
|
I'm fine with the proposed change. I actually planned to do this myself a
while back. :-)
…On Sat, Dec 24, 2016 at 3:13 PM Timothée Peignier ***@***.***> wrote:
I intentionally did not do some of the work, waiting to see if that idea
gain consensus.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3820 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGVyjY_FFXFO3ExpYIwKALN4BEQ04TMks5rLRpcgaJpZM4LVNKe>
.
|
bbatsov
reviewed
Dec 24, 2016
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### New features | |||
|
|
|||
| * [#3820](https://github.com/bbatsov/rubocop/pull/3820): Rename `Lint/Eval` to `Security/Eval`. ([@cyberdelia][]) | |||
There was a problem hiding this comment.
This should actually be under "Changes".
|
You'll also have to rebase this due to the fact your other PR just got merged. |
|
Rebased and changed. |
pocke
added a commit
to pocke/rubocop
that referenced
this pull request
Jan 14, 2017
This change improves obsolete warnings in three ways. 1. Show all obsoletes -------- Currently, RuboCop displays first obsolete warning only. ```yaml # two obsolete cops Style/SingleSpaceBeforeFirstArg: Enabled: false Style/SpaceBeforeModifierKeyword: Enabled: false ``` ``` Error: The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to `Style/SpaceBeforeFirstArg. (obsolete configuration found in /tmp/tmp.9T2ers7SW8/.rubocop.yml, please update it) ``` This change makes to display all obsolete warnings. ``` Error: The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to `Style/SpaceBeforeFirstArg.` (obsolete configuration found in /tmp/tmp.9T2ers7SW8/.rubocop.yml, please update it) The `Style/SpaceBeforeModifierKeyword` cop has been removed. Please use `Style/SpaceAroundKeyword` instead. (obsolete configuration found in /tmp/tmp.9T2ers7SW8/.rubocop.yml, please update it) ``` 2. Add obsolete cops --------- `Style/MethodCallParentheses` and `Lint/Eval` are renamed. - rubocop#3797 - rubocop#3820 So, I added the cops to `OBSOLATE_COPS`. 3. Add obsolete parameters In rubocop#3765, some cop's parameters are renamed. So, I added the parameters to `OBSOLATE_PARAMETERS`
11 tasks
bbatsov
pushed a commit
that referenced
this pull request
Jan 14, 2017
This change improves obsolete warnings in three ways. 1. Show all obsoletes -------- Currently, RuboCop displays first obsolete warning only. ```yaml # two obsolete cops Style/SingleSpaceBeforeFirstArg: Enabled: false Style/SpaceBeforeModifierKeyword: Enabled: false ``` ``` Error: The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to `Style/SpaceBeforeFirstArg. (obsolete configuration found in /tmp/tmp.9T2ers7SW8/.rubocop.yml, please update it) ``` This change makes to display all obsolete warnings. ``` Error: The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to `Style/SpaceBeforeFirstArg.` (obsolete configuration found in /tmp/tmp.9T2ers7SW8/.rubocop.yml, please update it) The `Style/SpaceBeforeModifierKeyword` cop has been removed. Please use `Style/SpaceAroundKeyword` instead. (obsolete configuration found in /tmp/tmp.9T2ers7SW8/.rubocop.yml, please update it) ``` 2. Add obsolete cops --------- `Style/MethodCallParentheses` and `Lint/Eval` are renamed. - #3797 - #3820 So, I added the cops to `OBSOLATE_COPS`. 3. Add obsolete parameters In #3765, some cop's parameters are renamed. So, I added the parameters to `OBSOLATE_PARAMETERS`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to move the Eval cop to Security/Eval, this is in order to have all the security checks under the same umbrella.
I'm not sure about the transition, I'm open to suggestions.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).