Fix redundant self cop for arguments

[mbj]

IMHO using the self keyword is legit to evade a name clash with arguments.

Also I added a more verbose description of this cop and the nuances that must be taken into account when dealing with self.

Best,

Markus

[bbatsov]

I'd suggest defining on_blockarg explicitly and calling the same helper method in both on_arg and on_blockarg. The alias_method pattern as used here is something we're moving away from.

[jonas054]

Oh. Then I have some updating to do in code that I've contributed. 😄

[bbatsov]

Nice work. Just update the Changelog, squash the commits and shorten the offending lines to get the build passing.

[mbj]

@bbatsov You insist of squashing the release? I'm totally happy with my series of commits tell the truth. And the truth is, I'm not able to do all changes at once.

[bbatsov]

I like to have commits that represent a coherent unit of work - remove debug comments, fix docs, better naming, etc don't fit that bill. Such commits are just noise in the log IMHO and should be avoided whenever possible.

[mbj]

@bbatsov I invalidated the true history, and our conversation here, via squashing the commits and force pushing the new one into this branch. Have to admit I dont like this, but your repo, your rules.

Hope this can be merged now!