Run RuboCop over its self for the default rake task #571
Conversation
| @@ -23,7 +23,15 @@ task :coverage do | |||
| Rake::Task['spec'].execute | |||
| end | |||
|
|
|||
| task default: :spec | |||
| desc 'Run RuboCop over its self' | |||
| task :inception do | |||
There was a problem hiding this comment.
Already there's Rubocop::RakeTask.
https://github.com/bbatsov/rubocop/blob/503478cf9c07affaebd4c66d04dd4fd7b0449314/README.md#rake-integration
There was a problem hiding this comment.
Oh, perfect! I'll switch it over to that
There was a problem hiding this comment.
Or, maybe not.
It adds a fair bit of load time to the rake file (quarter of a second on my MBP). How perf-sensitive should I be here, @bbatsov? (Though, I suppose the better approach is to optimize the load time of rubocop/rake_task in general, if it's a concern)
There was a problem hiding this comment.
Actually, just committed best of both worlds
Run RuboCop over its self for the default rake task
|
@nevir Nice solution! |
| @@ -23,7 +24,10 @@ task :coverage do | |||
| Rake::Task['spec'].execute | |||
| end | |||
|
|
|||
| task default: :spec | |||
| desc 'Run RuboCop over its self' | |||
There was a problem hiding this comment.
"its self"? Not "itself"?
I think this'll help a lot for contributors (the current breakage on master, and I ran into it on my other pull requests too) - force us to check style by default :)