Alias cop does auto-correction. #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.0%) when pulling 25d1add43f3ae6dcfa71e741ca74118a1b5fdf25 on dblock:autocorrect-alias-cop into 1b0338b on bbatsov:master. |
|
Coverage increased (+0.0%) when pulling 25d1add43f3ae6dcfa71e741ca74118a1b5fdf25 on dblock:autocorrect-alias-cop into 1b0338b on bbatsov:master. |
| @@ -13,6 +13,11 @@ | |||
| .to eq(['Use alias_method instead of alias.']) | |||
| end | |||
|
|
|||
| it 'autocorrects alias with symbol args' do | |||
There was a problem hiding this comment.
It's not as simple as that - alias's arguments can be:
- symbols
- strings
- barewords
In case they are strings or barewords you'll have to convert them to symbols.
There was a problem hiding this comment.
Right about barewords, but not string:
1.9.3p448 :001 > class Foo
1.9.3p448 :002?> def bar
1.9.3p448 :003?> "bar"
1.9.3p448 :004?> end
1.9.3p448 :005?>
1.9.3p448 :006 > alias "foo" "bar"
1.9.3p448 :007?> end
SyntaxError: (irb):6: syntax error, unexpected tSTRING_BEG
alias "foo" "bar"
^
from /Users/dblock/.rvm/rubies/ruby-1.9.3-p448/bin/irb:16:in `<main>'
1.9.3p448 :008 >
There was a problem hiding this comment.
Seems you're right. I guess the documentation here http://ruby-doc.org/docs/keywords/1.9/ is incorrect.
|
Updated to autocorrect barewords. |
bbatsov
added a commit
that referenced
this pull request
Dec 5, 2013
Alias cop does auto-correction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.