Add rules for hexadecimal, binary and decimal literal prefixes #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasbubane
force-pushed
the
hex-binary-literals
branch
from
73e333f to
e1080af
Compare
9 tasks
|
There's also the rather pointless |
tejasbubane
force-pushed
the
hex-binary-literals
branch
3 times, most recently
from
f1dacd0 to
f1e6bb0
Compare
|
@cremno Thanks! Did not know about the And yes, the 4 very similar sections looked kinda ugly. I have combined them into a single section. |
|
I think you've misunderstood me. The following would make sense to me:
And maybe (@bbatsov?):
|
|
|
|
My comment is just an example of how I would arrange the sections. I didn't want to propose anything in it as official wording or criticize yours. |
Related to rubocop#578 @bbatsov suggested to add rule for hex numbers. I went ahead and added one for binary as well.
tejasbubane
changed the title
tejasbubane
force-pushed
the
hex-binary-literals
branch
from
f1e6bb0 to
3775216
Compare
|
Looks good to me. |
pocke
pushed a commit
to pocke/ruby-style-guide
that referenced
this pull request
Feb 7, 2017
Related to rubocop#578 @bbatsov suggested to add rule for hex numbers. I went ahead and added one for binary as well.
ellimist
pushed a commit
to ellimist/ruby-style-guide
that referenced
this pull request
Mar 15, 2017
Related to rubocop#578 @bbatsov suggested to add rule for hex numbers. I went ahead and added one for binary as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #578
@bbatsov suggested to add rule for hex numbers. I went ahead and added
one for binary as well.