Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create loading page #1248

Closed
1 task done
bcmn opened this issue Feb 7, 2019 · 1 comment · Fixed by #1589
Closed
1 task done

Create loading page #1248

bcmn opened this issue Feb 7, 2019 · 1 comment · Fixed by #1589
Assignees
@chris-hinds

Comments

@bcmn
Copy link
Contributor

bcmn commented Feb 7, 2019 •
edited by greenc05
Loading

Is your feature request related to a problem? Please describe.
Our current loading state for second page load is a blank page with the text Loading.... We should create a loading screen that maintains much of the page furniture (&, depending on UX requirements, may render a "skeleton screen" or similar preview.

Adding a smoother transition to this screen is covered in #1302 which doesnt block this.

Blocked on UX's specifications for load page appearance.

Describe the solution you'd like
This should follow https://bbc.github.io/gel/foundations/routing/#awaiting-content

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.
@bcmn bcmn added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. must labels Feb 7, 2019
@dr3 dr3 mentioned this issue Feb 17, 2019
Closed
1 task
@dr3
Copy link
Contributor

dr3 commented Feb 17, 2019

Have edited this issue to be for the visual loading state only. Its bounce handling is covered by #1302

@ChrisBAshton ChrisBAshton removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Feb 18, 2019
@dr3 dr3 changed the title Handle loading state with minimal bounce Create loading page Feb 21, 2019
@ChrisBAshton ChrisBAshton added blocked This issue should not be worked on until another internal issue is completed - see desc for details v1.1 and removed v1.0 labels Mar 13, 2019
@sareh sareh mentioned this issue Mar 28, 2019
Closed
4 tasks
@chris-hinds chris-hinds mentioned this issue Apr 12, 2019
Merged
4 tasks
@chris-hinds chris-hinds added simorgh-core-stream and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Apr 16, 2019
@chris-hinds chris-hinds self-assigned this Apr 16, 2019
@itimirichard itimirichard mentioned this issue Nov 5, 2019
Merged
4 tasks
@itimirichard itimirichard mentioned this issue Dec 24, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-hinds chris-hinds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hoc loading error states bbc/simorgh
4 participants
@ChrisBAshton @dr3 @bcmn @chris-hinds