Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid css - Padding auto #2188

Closed
dr3 opened this issue Jun 30, 2019 · 0 comments · Fixed by #2193
Closed

Invalid css - Padding auto #2188

dr3 opened this issue Jun 30, 2019 · 0 comments · Fixed by #2193
Assignees
@jroebu14
Labels
bug Something isn't working ws-articles Tasks for the WS Articles Team

Comments

@dr3
Copy link
Contributor

dr3 commented Jun 30, 2019

Describe the bug
Introduced by #1900, a padding value of auto isn't valid CSS

To Reproduce
See https://github.com/bbc/simorgh/blob/latest/src/app/lib/layoutGrid/index.js#L132

Expected behavior
We dont use 'auto' for padding

Additional context
See https://www.w3.org/TR/CSS22/box.html#padding-properties for spec
@dr3 dr3 added bug Something isn't working ws-articles Tasks for the WS Articles Team labels Jun 30, 2019
@dr3 dr3 mentioned this issue Jun 30, 2019
Closed
@jroebu14 jroebu14 self-assigned this Jul 1, 2019
@jroebu14 jroebu14 mentioned this issue Jul 1, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jroebu14 jroebu14

Labels
bug Something isn't working ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid css bbc/simorgh
2 participants
@jroebu14 @dr3