add presentation role to root div #9828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarioR01
added
a11y
greenc05
reviewed
Jan 31, 2022
| <div id="root" dangerouslySetInnerHTML={{ __html: html }} /> | ||
| <div | ||
| id="root" | ||
| role="presentation" |
There was a problem hiding this comment.
Could we add a note/comment somewhere to say what this if for please?
|
Closing this to clean up our workspace. If we decide to make this change is very easy to re-implement. I linked this PR to the main issue for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9746
Overall change:
role presentation added to the root div. More info in the issue linked above.
Code changes:
cross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)