You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have an E2E test that sometimes fails. The test takes the social embed URLs from the json and scrolls to the top 3 in turn, with a wait of 3 seconds in between to allow time for them to appear with the lazy loading. It counts the number of ‘.instagram-media-rendered’ that appear. These appear when the social media embed renders.
Here is an example of one of the tests failing on this:
It expected 3 social embeds to render, but only counted 1. This is either because they loaded too slowly and the test scrolled past before counting them, or they didn't render at all.
I had a look at the page to see if I can see this happening manually and I did catch one of the social embeds not rendering at all, so it is a real problem:
The comments above the test read
// This test specifically covers an edge case where more than one instagram post is
// included in a Story and instagram needs to be prompted to render the instagram post
// rather than leaving it as core content
//
// Specifically it runs against this asset http://localhost:7080/russian/news-55041160
// but should pass against any page Story page with 2 or more instagram posts
The text was updated successfully, but these errors were encountered:
Spoke to Lily about the frequency of errors since PR was merged. It has occurred once since the last PR (#9826) was merged. Issue is low priority for now.
We have an E2E test that sometimes fails. The test takes the social embed URLs from the json and scrolls to the top 3 in turn, with a wait of 3 seconds in between to allow time for them to appear with the lazy loading. It counts the number of ‘.instagram-media-rendered’ that appear. These appear when the social media embed renders.
Here is an example of one of the tests failing on this:
It expected 3 social embeds to render, but only counted 1. This is either because they loaded too slowly and the test scrolled past before counting them, or they didn't render at all.
I had a look at the page to see if I can see this happening manually and I did catch one of the social embeds not rendering at all, so it is a real problem:
The comments above the test read
// This test specifically covers an edge case where more than one instagram post is
// included in a Story and instagram needs to be prompted to render the instagram post
// rather than leaving it as core content
//
// Specifically it runs against this asset http://localhost:7080/russian/news-55041160
// but should pass against any page Story page with 2 or more instagram posts
The text was updated successfully, but these errors were encountered: