Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Flourish include expects only valid JSON but shared messaging API with ads #9918

Open
LilyL0u opened this issue Mar 4, 2022 · 0 comments
Assignees
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) includes CPS story page includes

Comments

@LilyL0u
Copy link
Contributor

LilyL0u commented Mar 4, 2022

https://www.test.bbc.com/mundo/23263889

I had put a Flourish include on this test page. It was causing this application error to fail the E2E tests:

Screenshot 2022-03-02 at 15 21 35

With some digging by @andrewscfc, we found that the message.event is expecting JSON but it is also being used by ads on that page, and they are not sending valid json. This is why we get an unexpected token of a letter, and it varies what that letter is; that letter is what is being received first instead of the valid JSON opener {.

Now I am sure @andrewscfc can explain this better. If necessary I can get screenshots to give more detail.

I can put the include back in if it is needed for fixing the bug, but it does cause application errors in the simorgh pipeline e2es.

@LilyL0u LilyL0u changed the title Bug - Flourish include expects only vaiid JSON but shared messaging API with ads Bug - Flourish include expects only valid JSON but shared messaging API with ads Mar 4, 2022
@LilyL0u LilyL0u self-assigned this Mar 4, 2022
@LilyL0u LilyL0u added bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) includes CPS story page includes labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) includes CPS story page includes
Projects
None yet
Development

No branches or pull requests

1 participant