Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual failures are not checked on deleteMessageBatch #193

Closed
AntonioJuliano opened this issue Nov 13, 2019 · 3 comments
Closed

Individual failures are not checked on deleteMessageBatch #193

AntonioJuliano opened this issue Nov 13, 2019 · 3 comments

Comments

@AntonioJuliano
Copy link

Description

In consumer#deleteMessageBatch when batch deleting messages individual failures are not checked. As per the AWS docs "Because the batch request can result in a combination of successful and unsuccessful actions, you should check for batch errors even when the call returns an HTTP status code of 200"

Expected behaviour

The return value of this.sqs.deleteMessageBatch in the callback specifies a list of failed IDs, which should be validated to be empty. If any IDs fail, they should either be retried or the error should be surfaced

Actual behaviour

Individual failures are silent

Steps to reproduce

Have AWS return a non-empty Failed array

@AntonioJuliano
Copy link
Author

Also, the same thing with terminateVisabilityTimeoutBatch

@nspragg
Copy link
Contributor

nspragg commented May 12, 2020

@AntonioJuliano - thanks for raising this issue.

@nicholasgriffintn
Copy link
Member

I believe this will be resolved at the same time as this issue:

#245

Which is to return a list of successful messages, which when compared would also give you a list of failed messages.

Feel free to reopen if that doesn't resolve this issue.

@nicholasgriffintn nicholasgriffintn removed this from the TBD milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants