Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 307 (Temporary Redirect) and 308 (Permanent Redirect) properly #70

Open
nevali opened this issue Apr 28, 2017 · 1 comment
Open

Comments

@nevali
Copy link
Member

nevali commented Apr 28, 2017

Internal tracking: RESDATA-1179

@nickshanks
Copy link

I came to this issue after spotting the code if(status > 300 && status < 304) at https://github.com/bbcarchdev/anansi/blob/develop/libspider/processors/rdf.c#L162 and the 2xx check a few lines later.

I wanted to find out why other 3xx status codes were not included and why attempts are made to process response with codes like 202 and 206. Also, 203 should probably be rejected for integrity reasons.

In my opinion, processing would be more predictable if the first check was if(status >= 300 && status < 400) and the second was if(status != 200).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants