Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Error message check: key "extra": field was not used: parenthesized for v2.6.0 #67

Closed
zurk opened this issue Mar 12, 2019 · 2 comments
Closed
Labels

Comments

@zurk
Copy link

zurk commented Mar 12, 2019

There is a file that is parsable with v1.2.0 driver but not with v2.6.0
Full error mesage

Errors:
	- transform failed: received 2 errors:
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized

How to reproduce

wget https://raw.githubusercontent.com/hakimel/reveal.js/0b3e7839ebf4ed8b6c180aca0abafa28c67aee6d/js/reveal.js

v2.6.0 javascript-driver


docker run -d --rm --name bblfshd_new_driver --privileged bblfsh/bblfshd\:v2.11.0 --log-level DEBUG
docker exec bblfshd_new_driver bblfshctl driver install javascript docker://bblfsh/javascript-driver:v2.6.0
docker cp reveal.js bblfshd_new_driver:reveal.js
docker exec -it bblfshd_new_driver bblfshctl parse reveal.js

v1.2.0 javascript-driver (the same script, just install another driver and give different name)

docker run -d --rm --name bblfshd_old_driver --privileged bblfsh/bblfshd\:v2.11.0 --log-level DEBUG
docker exec bblfshd_old_driver bblfshctl driver install javascript docker://bblfsh/javascript-driver:v1.2.0
docker cp reveal.js bblfshd_old_driver:reveal.js
docker exec -it bblfshd_old_driver bblfshctl parse reveal.js

Last command prints UAST. Be careful, it is huge.

@zurk zurk changed the title Error message check: key "extra": field was not used: parenthesized Error message check: key "extra": field was not used: parenthesized for v2.6.0 Mar 12, 2019
@bzz bzz added this to the 2.7.0 release milestone Mar 12, 2019
@bzz
Copy link
Contributor

bzz commented Mar 12, 2019

Thank you for the report! This has been already fixed by #57 and going to be included in upcoming v2.7.0

Going to keep it open, until you could verify it

@bzz bzz added the bug label Mar 12, 2019
@bzz bzz removed this from the 2.7.0 release milestone Mar 12, 2019
@zurk
Copy link
Author

zurk commented May 22, 2019

yes, it works for v2.7.0
thanks!

@zurk zurk closed this as completed May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants