-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebMock::Util::Headers.normalize_headers
downcases characters in header keys
#863
Comments
@ulyssesrex thank you for pointing that. SOAPAction is indeed a culprit. I guess this can be changed in WebMock but with major version change in WebMock as I it would break many existing WebMock setups, where people set header expectations using e.g lowercase. |
The normalized form of headers which is enforced by HTTP/2 is lowercase. |
Thank you for the input @ioquatix It's only for HTTP/2 right? |
It's also for HTTP/1. https://stackoverflow.com/questions/5258977/are-http-headers-case-sensitive HTTP/2 just makes it an error and servers will drop the connection. |
Just FYI, this will become standard rack behaviour too: rack/rack#1592 |
This stub, chained with
with()
, will never match its intended request...because the stub's
HeadersPattern
has been normalized and no longer matches the given header. NoteSoapaction
instead ofSOAPAction
.The text was updated successfully, but these errors were encountered: