Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect psalmed toned when there is a star at the end #74

Open
mildred opened this issue May 13, 2024 · 1 comment
Open

Incorrect psalmed toned when there is a star at the end #74

mildred opened this issue May 13, 2024 · 1 comment

Comments

@mildred
Copy link

mildred commented May 13, 2024

Here, it seems the psalm toned feature does not work when there is a star at the end of the piece like for Ascentio Alleluia:

https://bbloomf.github.io/jgabc/propers.html#sunday=Asc#styleIntroitus=psalm-tone#styleTractus=psalm-tone;1f#styleAlleluia=psalm-tone#styleOffertorium=psalm-tone#styleCommunio=psalm-tone#styleGraduale=psalm-tone

Here is what it does:

image

This is what I believe it should do:

image

This seems caused by a star at the end of the piece:

image

@bbloomf
Copy link
Owner

bbloomf commented May 13, 2024

Thanks. I will take a look at fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants