Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate switch to Histoire #39

Closed
laurensgroeneveld opened this issue Mar 20, 2023 · 1 comment
Closed

Investigate switch to Histoire #39

laurensgroeneveld opened this issue Mar 20, 2023 · 1 comment
Assignees
Labels
quality Label defines issues that improve quality of a code

Comments

@laurensgroeneveld
Copy link
Collaborator

Investigate a switch to Histoire as a replacement for Storybook. As a Vite/Vue-native package it seems to fit pretty well with our usecase, and solve some pain points from Storybook, such as args declaration or the ability to have local reactive variables.

Acceptance criteria

  • Set up a POC with Histoire, converting our most intricate component, the button, to it
  • Decide whether it is a better approach than Storybook
  • If so, convert all remaining stories to Histoire
    • Update deploy script
This was referenced Mar 23, 2023
@laurensgroeneveld laurensgroeneveld self-assigned this Mar 24, 2023
@laurensgroeneveld laurensgroeneveld added the quality Label defines issues that improve quality of a code label Mar 28, 2023
@laurensgroeneveld
Copy link
Collaborator Author

With the upgrade to Storybook v7 in #61 most issues we had with Storybook are solved. Histoire still seems like a good option in the future since the stories are just native Vue instead of compiled strings, but the downsides feel too much at the moment, primarily:

  • Very bad automatic recognition of props, only boolean props render a proper control by default (a checkbox)
  • Lots of markup needed for a radio group for example
  • No ability to view all stories on one page

@laurensgroeneveld laurensgroeneveld closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Label defines issues that improve quality of a code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant