Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: restore window as maximized #294

Open
kkuepper opened this issue Feb 10, 2024 · 2 comments
Open

Windows: restore window as maximized #294

kkuepper opened this issue Feb 10, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Community can help with implementing this

Comments

@kkuepper
Copy link
Member

Right now, it's not restored as maximized. Since I have a Mac it would be a lot easier if someone working on Windows could work on this.

See electron/main.ts where window.setBounds() is called.
electron/electron#526 should give some hints on how to fix it.

@kkuepper kkuepper added good first issue Good for newcomers help wanted Community can help with implementing this labels Feb 10, 2024
@leo-schick
Copy link

There is definitively something to fix here. I am not sure if it should be maximized by default, but a bit bigger would be great by default. When I first opened it, it looked like this on my screen:

image

resolution 1920x1080 (1080p).

@kkuepper
Copy link
Member Author

kkuepper commented Apr 11, 2024

@leo-schick For now, we're just using a safe size that doesn't cause problems. It would be better to increase the size if the screen has more space, but that requires additional code.

Also, it's only relevant the first time you open the app. After that it uses the screen size it had when it was closed.

Feel free to create a PR: https://github.com/bcc-code/bmm-web/blob/main/electron/main.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Community can help with implementing this
Projects
None yet
Development

No branches or pull requests

2 participants