Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export email download link incorrect #1214

Open
bferguso opened this issue Jan 9, 2025 · 1 comment
Open

Export email download link incorrect #1214

bferguso opened this issue Jan 9, 2025 · 1 comment
Assignees
Labels
Arches Core Bug fossils Fossils Specific Issue

Comments

@bferguso
Copy link
Collaborator

bferguso commented Jan 9, 2025

The default email indicating the export is ready for download now has a download link, however the link is incorrect. Should either remove the download link or correct the download URL.

Emails are currently disabled for BCRHP so this is only an issue for BCFMS for now.

@bferguso bferguso added Arches Core Bug fossils Fossils Specific Issue labels Jan 9, 2025
@bferguso bferguso added this to the Upgrade to 7.6.x milestone Jan 9, 2025
@bferguso bferguso self-assigned this Jan 9, 2025
@bferguso
Copy link
Collaborator Author

I have a potential solution in place which involves a couple of changes:

  1. Updating Arches Core to split the PUBLIC_SERVER_ADDRESS from the WEBPACK_SERVER_ADDRESS (PUBLIC_SERVER_ADDRESS value can have conflicting requirements archesproject/arches#11723)
  2. Changing the logic that creates the email URL to generate the target S3 URL rather than an Arches internal URL.

Some things to consider:

  1. Is it OK to put the S3 URL directly in the email? NB - the URLs are publicly available anyway.
  2. The authorization key for access to the S3 store is likely shorter than the length of time the export file will be accessible. Need to update the email description to reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arches Core Bug fossils Fossils Specific Issue
Projects
None yet
Development

No branches or pull requests

1 participant