Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge NewQRView and QRScanner components #2377

Closed
bryce-mcmath opened this issue Feb 11, 2025 · 0 comments
Closed

Merge NewQRView and QRScanner components #2377

bryce-mcmath opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
task/technical-debt Technical Debt

Comments

@bryce-mcmath
Copy link
Contributor

From our tech debt list:

NewQRView.tsx is essentially the scan screen that is gated behind the developer setting, "Use connection inviter capability". Maintaining both views separately requires a bit of doubled effort and they are similar enough that they cause SonarCloud duplication failures. They should be merged and handle the different behaviour as one component. This will also prevent fixes and features going into one component but not the other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task/technical-debt Technical Debt
Projects
None yet
Development

No branches or pull requests

2 participants