Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calc_* functions should output NAs is there is no available data #135

Closed
CeresBarros opened this issue Dec 14, 2023 · 1 comment
Closed

calc_* functions should output NAs is there is no available data #135

CeresBarros opened this issue Dec 14, 2023 · 1 comment
Assignees
@CeresBarros
Labels
to do validation checking that things are working properly

Comments

@CeresBarros
Copy link
Member

Some calc_* functions are returning 0s even when there's not base climate data to calculate the variable of concern (degree days is an example). Since 0s are often sensible climate variable values, we should make NAs be returned in this case.
@CeresBarros CeresBarros added validation checking that things are working properly to do labels Dec 14, 2023
@CeresBarros CeresBarros self-assigned this Dec 14, 2023
@CeresBarros CeresBarros mentioned this issue Dec 19, 2023
Merged
@CeresBarros
Copy link
Member Author

fixed in #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CeresBarros CeresBarros

Labels
to do validation checking that things are working properly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CeresBarros