Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-WEB - NR's for COLIN actions should not advise to add the business in MBR #18125

Closed
8 tasks
Mihai-QuickSilverDev opened this issue Oct 6, 2023 · 7 comments
Closed
8 tasks
Assignees
Labels
bug Something isn't working Pay Work for Pay Team

Comments

@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented Oct 6, 2023

  • Name Change NR, for a BC Ltd. company is instructing the user to add the business to the MBR, in order to proceed with the name change.
  • Also Alteration from BC Ltd. to ULC.
  • Because the BC Ltd. is not in BCROS, the affiliation would fail, and most likely we would end-up with a call/ticket.

How to replicate the issue:

  • Login to BCROS TEST as BCREG0020
  • Locate this NR
    Private Zenhub Image
  • Click on Change Name Now
  • Observe the message displayed on the screen:
    Private Zenhub Image
    To Do List:
  • When clicking on Change Name Now launch a redirect to COLIN instead.
  • [ ]
    There are more NR types in this situation, work can start now, and would update this ticket for Thursday.
@Mihai-QuickSilverDev Mihai-QuickSilverDev added ENTITY Business Team Pay Work for Pay Team labels Oct 6, 2023
@Mihai-QuickSilverDev
Copy link
Collaborator Author

Mihai-QuickSilverDev commented Oct 6, 2023

Message from Dave to Travis:
Hi Travis,
I just wanted to give you a heads up, we found a bug. I believe it’s in Auth Web when a user should be redirected to COLIN as part of the Way of Navigating. Mihai is creating a ticket right now and I’ve asked him to assign the ticket to you.
If you don’t think it’s there or rightly be assigned to my team, just let me know.
Thanks,
Dave

@Mihai-QuickSilverDev
Copy link
Collaborator Author

@severinbeauvais
Copy link
Collaborator

A quick solution would be to use the "IA" feature flag to determine whether to open the business locally or redirect to COLIN

(The IA FF determines whether to handle IAs locally or redirect to COLIN, depending on whether the entity type is supported. This should be OK initially because we don't handle IAs or name changes or alterations for the unsupported entity types. Ultimately, name change and alteration should have their own FFs.)

Ultimately, we might want two new FFs, so that we can deploy new IAs separately from new name changes or alterations.

@JohnamLane JohnamLane added the bug Something isn't working label Oct 10, 2023
@jdyck-fw jdyck-fw removed the ENTITY Business Team label Oct 10, 2023
@jdyck-fw
Copy link
Collaborator

@seeker25 @PCC199 - I believe this is intended to be in Relationships sprint.

@seeker25 seeker25 changed the title NR's for COLIN actions should not advise to add the business in MBR AUTH-WEB - NR's for COLIN actions should not advise to add the business in MBR Oct 10, 2023
@seeker25
Copy link
Collaborator

I've put in a check to look if it's a modernized entity (looking at the IA feature flag). If it isn't, it redirects to COLIN. If it is, the error above still persists.

DEV has this feature flag wide open, TEST and PROD are way more limited (should see the redirect to COLIN).

@seeker25
Copy link
Collaborator

Should be on test in 15m

@severinbeauvais
Copy link
Collaborator

Ultimately, we might want two new FFs, so that we can deploy new IAs separately from new name changes or alterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

5 participants