Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namex API: should not return CANCELLED (refunded) NRs #18203

Closed
severinbeauvais opened this issue Oct 17, 2023 · 5 comments
Closed

Namex API: should not return CANCELLED (refunded) NRs #18203

severinbeauvais opened this issue Oct 17, 2023 · 5 comments
Assignees
@eve-git
Labels
bug Something isn't working ENTITY Business Team Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority2

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 17, 2023 •
edited
Loading

  1. login as staff in Prod
  2. go to MBR
  3. search for NR 1733145 (which is cancelled)

Expected result: NR is not returned in search

Actual result:

image

image

image
@severinbeauvais severinbeauvais added bug Something isn't working ENTITY Business Team NameX NameX and related services proxied via namex Priority2 labels Oct 17, 2023
@severinbeauvais severinbeauvais changed the title Namex API: should not return CANCELLED (refund) NRs Namex API: should not return CANCELLED (refunded) NRs Oct 17, 2023
@ozamani9gh ozamani9gh added the Names Team Name Request Name Examination Team label Oct 26, 2023
@github-actions github-actions bot mentioned this issue Nov 16, 2023
Closed
This was referenced Nov 16, 2023
Closed
Closed
Closed
Closed
@eve-git eve-git self-assigned this Feb 2, 2024
@eve-git
Copy link
Collaborator

eve-git commented Feb 2, 2024 •
edited
Loading

An error popped up when I tried to reproduce the issue in DEV environment. The same as in PROD environment.
image.png

@eve-git
Copy link
Collaborator

eve-git commented Feb 2, 2024

@severinbeauvais could you confirm if the error still exists?

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Feb 2, 2024 •
edited
Loading

I tried affiliating NR 1733145 and got the following, as expected:

image

Therefore, the original issue no longer reproduces.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Feb 2, 2024 •
edited
Loading

However, it looks like you found a new problem: NR 4000103 is returned by the search but cannot be affiliated:

image

Either:

  • don't return a NR that cannot be affiliated
    or
  • display in the error modal that the NR might be an invalid status (because it's not a phone number or email address issue)

I don't know if the new issue is related to the original issue. If it isn't, please create a new bug ticket.

@eve-git
Copy link
Collaborator

eve-git commented Feb 6, 2024

#19703 is opened for the new issue.
The ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eve-git eve-git

Labels
bug Something isn't working ENTITY Business Team Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@severinbeauvais @eve-git @ozamani9gh @oanyahuru