Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Help button in About business for AGM location change has a break while closing. #18513

Closed
riyazuddinsyed opened this issue Nov 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team Priority2

Comments

@riyazuddinsyed
Copy link
Collaborator

Describe the bug in the current situation
When the user starts AGM Location Change and clicks on the Help section and then when the user clicks back on Hide Help the component closes up but highlights the header.

Steps to reproduce the behavior:

  1. Go to 'https://test.business.bcregistry.gov.bc.ca/BC1062080/agm-location-chg'
  2. Login with BCREGA001/98900001
  3. Click on Help and then click on Hide Help Button
  4. The component closes but the focus on the header still remains.
@riyazuddinsyed riyazuddinsyed added bug Something isn't working ENTITY Business Team labels Nov 8, 2023
@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 9, 2023

The help panel closes correctly but the transition is a bit jerky.

As the fix will be to the shared ExpandableHelp component, AGM Extension help will also be fixed.

@severinbeauvais severinbeauvais self-assigned this Nov 9, 2023
@severinbeauvais
Copy link
Collaborator

I researched this and found other people who had similar complaints about the Vuetify "expand" transition.

I tried a few different transitions (scale, scroll-y and slide-y) and ultimately decided to change this to the slide-y transition with the "hide-on-leave" option.

Note that this fix is to a shared component, so all UIs that import the latest version will see the improved behaviour.

@severinbeauvais
Copy link
Collaborator

This is now fixed, reviewed, merged into Dev and RFQA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team Priority2
Projects
None yet
Development

No branches or pull requests

4 participants