Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI - Fix UXA notes for Amalgamation Filing #19201

Closed
7 of 8 tasks
JazzarKarim opened this issue Jan 10, 2024 · 2 comments
Closed
7 of 8 tasks

Create UI - Fix UXA notes for Amalgamation Filing #19201

JazzarKarim opened this issue Jan 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team timeboxed UX Assurance

Comments

@JazzarKarim
Copy link
Collaborator

JazzarKarim commented Jan 10, 2024

As per Yui's comment: #18689 (comment)

Need to fix:

  • When a not-in-good-standing business is added to the bus list and that business is made in-goos-standing, the business' status does not update on the amalgamation filing draft until the business is removed from the list and re-added. Reopening the draft/refreshing the page does not update the Status column. The status of the businesses in the list should update when the draft page is reloaded or the filing is re-opened.
  • Frozen business is appearing as "Ready" on the business list. We want to see Attention Required status with, "This business is frozen. Frozen businesses cannot be part of an amalgamation."
  • Historical business is showing up as Ready status in the business list.
  • Uncaught TypeError in console when loading draft image.png
  • Cannot get File and Pay to work possibly due to the type error above. image.png
  • Fix if the resulting business' name that was selected was removed from the table, we want to undo that automatically
  • Implemented FF to hide the amalgamate button based of it
  • Fix Create UI: implement new Amalgamating Businesses component - Part IV - DO THIS LAST #18641 (comment) should be fixed

Test Data:
Inc No. BC0871463, Phone: 1231231234 (historical)
Inc No. BC0871363, Phone: 1231231234 (frozen)
Inc No. BC 0871066, Phone: 1231231234

@JazzarKarim JazzarKarim added ENTITY Business Team bug Something isn't working labels Jan 10, 2024
@JazzarKarim JazzarKarim changed the title Create UI - Fix UXA notes for Amalgamation Create UI - Fix UXA notes for Amalgamation Filing Jan 10, 2024
@jdyck-fw
Copy link
Collaborator

This estimate will likely include more coming from Yui.

If it grows beyond a 3, then we cut another ticket.

@yuisotozaki
Copy link

Ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team timeboxed UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants