EFT - Changes to use invoice references

[seeker25]

https://github.com/bcgov/sbc-pay/blob/main/queue_services/payment-reconciliations/src/reconciliations/eft/eft_reconciliation.py

https://github.com/bcgov/sbc-pay/blob/main/pay-api/src/pay_api/services/eft_service.py

Update EFT service in pay_api

• create invoice should now generate the invoice reference (see direct pay service)
• re-evaluate apply_credit, we probably shouldn't be creating the invoice reference and receipt here any more
• remove any stale functions if no longer going to be used

Update EFT reconciliation

• update requirements.txt to new pay api once that is completed
• confirm unit tests work and updated to check against new invoice reference state
• review reconciliation to see if there is any logic that needs to be updated for receipts, etc
• keep in mind the reconciliation will need to fully rollback in the event of errors so the service methods being used apply_credit should not be commiting

[seeker25]

Hey team! Please add your planning poker estimate with Zenhub @Jxio @ochiu @rodrigo-barraza @seeker25