Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

500 Error in namex-api when searching for stop words #203

Closed
WalterMoar opened this issue Mar 4, 2019 · 18 comments
Closed

500 Error in namex-api when searching for stop words #203

WalterMoar opened this issue Mar 4, 2019 · 18 comments
Assignees
@kialj876
Labels
bug Something isn't working NameX NameX and related services proxied via namex
Milestone
SPRINT 2 - Tombst...

Comments

@WalterMoar
Copy link
Contributor

Describe the bug

A search in namex for "T.H.E." results in a 500 error. This happened in production on 2019-03-04 at 09:58, and was reproduced in the dev environment.

To Reproduce
Steps to reproduce the behavior:

  1. Go to namex.
  2. Click on Examine Names.
  3. Enter "T.H.E." in the search box.
  4. See error

Expected behavior

500 errors should not happen.
@WalterMoar WalterMoar added bug Something isn't working NameX NameX and related services proxied via namex labels Mar 4, 2019
@kialj876
Copy link
Collaborator

kialj876 commented Mar 4, 2019

The problem here is that after the punctuation is stripped we get 'the' which is then stripped out because it's a stopword so it turns into an empty string (which probably fails on the first solr call). Therefore the fix should just be handling an empty string search in solr.py

@WalterMoar
Copy link
Contributor Author

This happened again in production on March 5th 2019 at 13:58:33.707 for the search term "THAT":

2019-03-05 21:58:33,572 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/synonymbucket/THAT /*

@WalterMoar
Copy link
Contributor Author

This happened again in production on March 9th 2019 at 20:58:51.524 for the search term "ASSN":

2019-03-10 04:58:51,523 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/synonymbucket/ASSN/*

@WalterMoar WalterMoar changed the title 500 Error in namex-api when searching for T.H.E. 500 Error in namex-api when searching for stop words Mar 11, 2019
@WalterMoar
Copy link
Contributor Author

This happened again in production on March 12th 2019 at 12:06:53.863 for the search term "LIMITED CORP.":

2019-03-12 19:06:53,660 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/phonetics/LIMITED CORP./*

@WalterMoar
Copy link
Contributor Author

This happened again in production on March 14th 2019 at 08:04:06.960 for the search term "'N AND 'N":

2019-03-14 15:04:06,959 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/synonymbucket/'N AND 'N/*

@WalterMoar
Copy link
Contributor Author

WalterMoar commented Mar 18, 2019 •
edited
Loading

This happened again in production on March 15th 2019 at 11:28:38.953 for the search term "company":

2019-03-15 18:28:38,843 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/cobrsphonetics/company/*

@WalterMoar
Copy link
Contributor Author

This happened again in production on March 15th 2019 at 12:59:20.651 for the search term "AT ":

2019-03-15 19:59:20,534 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/synonymbucket/AT /*

@kialj876 kialj876 self-assigned this Mar 22, 2019
@WalterMoar
Copy link
Contributor Author

This happened again in production on March 22nd 2019 at 13:03:00.089 for the search term "IT":

2019-03-22 20:03:00,081 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/phonetics/IT/*

@WalterMoar
Copy link
Contributor Author

This happened again in production on March 25th 2019 at 09:43:22.577 for the search term "THIS ":

2019-03-25 16:43:22,572 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/phonetics/THIS /*

@kialj876 kialj876 mentioned this issue Mar 25, 2019
Merged
@WalterMoar
Copy link
Contributor Author

WalterMoar commented Mar 25, 2019 •
edited
Loading

This happened again in production on March 25th 2019 at 15:00:10.064 for the search term "'N AND 'N":

2019-03-25 22:00:10,062 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/phonetics/'N AND 'N/*

@kialj876 kialj876 mentioned this issue Mar 26, 2019
Merged
@WalterMoar
Copy link
Contributor Author

This happened again in production on March 26th 2019 at 14:08:18.366 for the search term "INTO THE ":

2019-03-26 21:08:18,366 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/synonymbucket/INTO THE /*

@WalterMoar
Copy link
Contributor Author

WalterMoar commented Mar 26, 2019 •
edited
Loading

This happened again in production on March 26th 2019 at 14:16:53.656 for the search term "IT ":

2019-03-26 21:16:53,655 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/synonymbucket/IT /*

@WalterMoar
Copy link
Contributor Author

This happened again in production on March 28th 2019 at 08:36:06.657 for the search term "IT":

2019-03-28 15:36:06,657 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/synonymbucket/IT/*

@WalterMoar
Copy link
Contributor Author

This happened again in production on March 28th 2019 at 09:20:00.586 for the search term "ASSOCIATION ":

2019-03-28 16:20:00,586 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/cobrsphonetics/ASSOCIATION /*

@WalterMoar
Copy link
Contributor Author

This happened again in production on April 11th 2019 at 10:02:31.311 for the search term "AN ":

2019-04-11 17:02:31,223 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/cobrsphonetics/AN /*

@WalterMoar
Copy link
Contributor Author

This happened again in production on April 12th 2019 at 10:00:23.274 for the search term "' ":

2019-04-12 17:00:23,273 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/cobrsphonetics/'/*

@WalterMoar
Copy link
Contributor Author

This happened again in production on April 12th 2019 at 12:09:34.819 for the search term " co":

2019-04-12 19:09:34,815 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/cobrsphonetics/ co/*

@WalterMoar
Copy link
Contributor Author

This happened again in production on April 17th 2019 at 14:54:37.461 for the search term "it":

2019-04-17 21:54:37,460 - flask.app - ERROR in app:app.py:1761 - log_exception: Exception on /api/v1/requests/phonetics/it/*

@kialj876 kialj876 closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kialj876 kialj876

Labels
bug Something isn't working NameX NameX and related services proxied via namex
Projects
None yet
Milestone
SPRINT 2 - Tombstone data and data co...
Development

No branches or pull requests
3 participants
@kialj876 @WalterMoar @Kaineatthelab