Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-API - Versioning table #20588

Closed
Jxio opened this issue Apr 3, 2024 · 3 comments
Closed

PAY-API - Versioning table #20588

Jxio opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
Pay Work for Pay Team

Comments

@Jxio
Copy link
Collaborator

Jxio commented Apr 3, 2024

  1. test versioning table

  2. might need to change the service pattern that pay is using
    some boilerplate like this, redundant code might need to change:
    @service_fee_client.setter
    def service_fee_client(self, value: str):
    """Set the service_fee_client."""
    self._service_fee_client = value

    @service_fee_distribution_code_id.setter
    def service_fee_distribution_code_id(self, value: int):
    """Set the service_fee_distribution_code_id."""
    self._service_fee_distribution_code_id = value
    self._dao.service_fee_distribution_code_id = value

@Jxio Jxio added the Pay Work for Pay Team label Apr 3, 2024
@Jxio Jxio self-assigned this Apr 3, 2024
@Jxio
Copy link
Collaborator Author

Jxio commented Apr 3, 2024

Hey team! Please add your planning poker estimate with Zenhub @ochiu @rodrigo-barraza @seeker25

@Jxio
Copy link
Collaborator Author

Jxio commented Apr 5, 2024

checked api post/patch request response version relate to eft_short_names, account_fees, cfs_accounts, refund_partial, payment_accounts, distribution_codes. all of versions increase by one for each request, except refund_partial, it got 500 error:
Pasted Graphic 2.png
image.png

@seeker25
Copy link
Collaborator

seeker25 commented Apr 6, 2024

Awesome great work Jia

@Jxio Jxio closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

2 participants