Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassign role: Viewer/Reviewer/TM/Superuser #1907

Closed
marieanik opened this issue Jul 27, 2023 · 3 comments
Closed

Reassign role: Viewer/Reviewer/TM/Superuser #1907

marieanik opened this issue Jul 27, 2023 · 3 comments
Assignees
Labels
UM testing UX/UI User testing, accessibility testing, Standardization

Comments

@marieanik
Copy link
Collaborator

marieanik commented Jul 27, 2023

As a Superuser, I want to be able to assign a different role to an existing user from the user management screen so that I can keep my users up-to-date in the system.

*Superuser toggle removed from User Details screen
*Engagement UM tab will remain to be only for TM
*Table should record role for TM/Reviewer (so that when a Reviewer becomes a TM, we know what engagement they were assigned to in a specific role)

@marieanik marieanik added In Analysis This task is not ready for dev yet UM testing UX/UI User testing, accessibility testing, Standardization labels Jul 27, 2023
@marieanik marieanik changed the title Reassign role: Viewer/Reviewer/TM Reassign role: Viewer/Reviewer/TM/Superuser Jul 28, 2023
@TayaLee8
Copy link
Collaborator

TayaLee8 commented Aug 4, 2023

From User Management tab on side navigation:
image.png
We will use Jane Doe for our scenario. (Team Member -> Superuser)

When Action drop down is clicked, you get two options: Assign to an Engagement (already existing) and Reassign Role.
When Reassign Role is clicked, you get Reassign Role pop-up:
image.png
All Role options will display except for their current role (if possible by devs). Jane Doe is assigned as a Superuser.

On User Details page, their Current Role will display at the top. The table will show the users history such as current/previous engagements, their role on each engagement, the date added to the engagement, their status on the engagement, and date revoked from the engagement (if applicable).
image.png

If a user is reassigned a role, they must be revoked from all engagements as their current role and reassigned as their new role. This is only not applicable for Superusers, as Superusers are not assigned engagements (they have access to everything). In this scenario, Jane Doe does not have any "Active" engagements because she is a Superuser. She was not revoked from her engagements as a Team Member because as a Superuser she still has access to them.

See full flow and rules here:
image.png

@jadmsaadaot
Copy link
Collaborator

Reading this task I misunderstood the part "and must be readded as a TM" to mean this should happen programmatically as the user is reassigned their new role. But after a further discussion this was pointed out to me that this is meant to happen manually. Meaning, the user is revoked from all their engagements and the process of reassignment them to engagements happens manually after the reassign user role event is done.

As a consequence of the misunderstanding a logic was added in the code to programmatically reassign users to their revoked memberships with the new role, which was later removed in a following PR. As thing stand, a user is revoked from their engagements after their role is reassigned.

@TayaLee8 TayaLee8 closed this as completed Sep 7, 2023
@TayaLee8 TayaLee8 reopened this Sep 7, 2023
@TayaLee8
Copy link
Collaborator

TayaLee8 commented Sep 7, 2023

Closing this and created related bugs:
#2144
#2143
#2145

@TayaLee8 TayaLee8 closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UM testing UX/UI User testing, accessibility testing, Standardization
Projects
None yet
Development

No branches or pull requests

3 participants