Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innkeeper plugin: normalize formatting/linting tools with other plugins #1406

Open
loneil opened this issue Oct 16, 2024 · 4 comments
Open
Labels
CICD pinned Pinned item that will never become stale testing Unit/Integration/Functional testing of static code or running applications

Comments

@loneil
Copy link
Contributor

loneil commented Oct 16, 2024

The Innkeeper plugin has black and flake8 set up as dev dependencies (https://github.com/bcgov/traction/blob/main/plugins/traction_innkeeper/pyproject.toml#L21). In the plugin repo the plugins are setup to use Ruff instead. We should match build processes for this plugin to the ones in the repo.

Alter dev dependencies and format/lint setup to be like the plugins repo. Make sure any GHA build processes for PRs and merges and such use the same patterns where possible when it comes to lint checks as well.

The innkeeper plugin also needs unit testing additions and dev tools for that should match as well, but that's covered in #946

@loneil loneil added testing Unit/Integration/Functional testing of static code or running applications CICD labels Oct 16, 2024
@loneil
Copy link
Contributor Author

loneil commented Oct 16, 2024

Tagging for any additional thoughts @jamshale

@jamshale
Copy link
Contributor

It's not really that important if there's not going to be a lot of changes to this plugin... But, yes it would be good to be consistent with the other plugins.

I think some basic unit testing coverage is more important, and possibly some integration testing like the plugins have. It has caught issues with libraries that aren't going to be caught with innkeeper until manually tested in traction UI.

I think when someone adds some tests they could updating the linting/formatting/docs at the same time.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 16, 2024
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@loneil loneil reopened this Nov 21, 2024
@loneil loneil added pinned Pinned item that will never become stale and removed Stale labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD pinned Pinned item that will never become stale testing Unit/Integration/Functional testing of static code or running applications
Projects
None yet
Development

No branches or pull requests

2 participants