Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot tests fail on fresh checkout #272

Closed
connorjclark opened this issue Dec 9, 2020 · 2 comments
Closed

snapshot tests fail on fresh checkout #272

connorjclark opened this issue Dec 9, 2020 · 2 comments
Labels
bug

Comments

@connorjclark
Copy link
Contributor

A fresh checkout results in this after running npm run test:snap

image

Node: v12.13.0
@connorjclark connorjclark mentioned this issue Dec 9, 2020
Merged
@bcoe bcoe added the bug label Dec 22, 2020
@bcoe
Copy link
Owner

bcoe commented Dec 22, 2020

@connorjclark what Node.js version are you running, I just deleted pacakge-lock.json and node_modules, and ran:

npm run test

And the snapshots don't throw any errors:

41 passing (16s)

My environment:

bencoe-macbookpro3:c8 bencoe$ node --version
v15.0.1

@connorjclark
Copy link
Contributor Author

Node 12.

I missed this line in CONTRIBUTING:

Make sure you have installed the latest version of Node.js

Tests pass for me using Node 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoe @connorjclark