Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance / optimizations with coverage enabled #3

Closed
schuay opened this issue Oct 27, 2017 · 2 comments
Closed

Performance / optimizations with coverage enabled #3

schuay opened this issue Oct 27, 2017 · 2 comments

Comments

@schuay
Copy link

schuay commented Oct 27, 2017

Opening a new ticket here to avoid derailing nodejs/node#16531:

code transpiled for test coverage runs significantly slower than the code prior to transpilation; I'm betting collecting coverage directly from v8 will be fast (although the subprocess shenanigans might add some overhead).

Turning on code coverage disables optimization in many cases. It may be possible to allow optimization in some modes (e.g. precise binary coverage, or possibly all detailed coverage modes), but this probably requires investigation.

@shinnn
Copy link
Contributor

shinnn commented Apr 20, 2019

Fixed in 3c1b92b.

@shinnn shinnn closed this as completed Apr 20, 2019
@bcoe
Copy link
Owner

bcoe commented May 1, 2019

@shinnn these performance issues actually related to V8, so up until recently still effected c8, however!, @schuay recently took on addressing these issues:

https://bugs.chromium.org/p/v8/issues/detail?id=9148

so I believe this can remain closed \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants