Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: column could be < 1 when wrapper taken into account #22

Merged
merged 1 commit into from
May 1, 2019

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented May 1, 2019

In Node.js 10, it was possible for the column position to be less than 1 after subtracting the wrapper; this problem should go away once nodejs/node#27124 is released.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 80

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.722%

Totals Coverage Status
Change from base Build 78: 0.0%
Covered Lines: 151
Relevant Lines: 157

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 80

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.722%

Totals Coverage Status
Change from base Build 78: 0.0%
Covered Lines: 151
Relevant Lines: 157

💛 - Coveralls

@bcoe bcoe merged commit aa3f73b into master May 1, 2019
@bcoe bcoe deleted the fix-edge-case branch May 1, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants