Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default server host should be localhost #10

Closed
pinheadmz opened this issue Jan 19, 2022 · 2 comments
Closed

Default server host should be localhost #10

pinheadmz opened this issue Jan 19, 2022 · 2 comments

Comments

@pinheadmz
Copy link
Member

The main reason for this is to match the default in bcurl/client:

https://github.com/bcoin-org/bcurl/blob/d7e088fad4c284fb5d6fd7205c6b903bd3e6bf83/lib/client.js#L371

Right now bweb hosts explicitly on ipv4:

this.host = '127.0.0.1';

and I believe this is causing issues on ipv6 enabled machines, such as handshake-org/hs-client#45

@pinheadmz
Copy link
Member Author

TODO follow-up, do we need to add "localhost" to this list of auto-authorized hostnames?

https://github.com/handshake-org/hsd/blob/master/lib/node/http.js#L890-L895

@pinheadmz
Copy link
Member Author

closing, see #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant