Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All caps words not getting capitalized #7

Open
Christilut opened this issue May 10, 2022 · 1 comment
Open

All caps words not getting capitalized #7

Christilut opened this issue May 10, 2022 · 1 comment

Comments

@Christilut
Copy link

Here are a few examples with incorrect output:

REMIX INTRO (Original Mix)
TEST STRING (Original Mix) (Feat. MC FOO)
VIBES! Feat. MC FOO
FOO! Feat. MC BAR
prologue the MAX (Original Mix)

Seems like maybe something like

	if (string.toUpperCase() === string) {
		string = string.toLowerCase();
	}

needs to be added to the capitalize() function?

Happy to make a PR, just wanted to check if someone will merge it.

@bdougherty
Copy link
Owner

Hmm, I don't think we can handle these without breaking the rules (last example, especially). The first could maybe work if each "container" was treated separately, but I'm not sure if that is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants