Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In log forward, include tensors saved for backward in size calculation #36

Open
bdusell opened this issue Jun 21, 2023 · 0 comments
Open

In log forward, include tensors saved for backward in size calculation #36

bdusell opened this issue Jun 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@bdusell
Copy link
Owner

bdusell commented Jun 21, 2023

When calculating the space required for the output tensors in the forward pass of log einsum, the tensors of max values and sumexpsub values are currently not included, leading to a very low estimate. Use output_dtypes to include them.
@bdusell bdusell added the bug Something isn't working label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdusell