Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Legolas._schema_version_from_record_type part of the API #109

Open
omus opened this issue Dec 21, 2023 · 1 comment
Open

Make Legolas._schema_version_from_record_type part of the API #109

omus opened this issue Dec 21, 2023 · 1 comment

Comments

@omus
Copy link
Member

omus commented Dec 21, 2023

I found myself using this internal function when attempting to identify the schema version from the element type of an iterator:

record_type = Base.@default_eltype(records)
record_type <: AbstractRecord || error("Unable to determine record type from iterator")
schema_version = Legolas._schema_version_from_record_type(record_type)
@ararslan
Copy link
Member

+1 from me, but note that this was intentionally omitted from the API; see #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omus @ararslan